Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README restructure #4863

Merged
merged 2 commits into from
Apr 11, 2018
Merged

README restructure #4863

merged 2 commits into from
Apr 11, 2018

Conversation

pkulikov
Copy link
Contributor

@pkulikov pkulikov commented Apr 3, 2018 •
edited
Loading

Restructured README:

  • Introduce the repo at the first paragraph.
  • Added link to the result of this repo
  • Put contributor-related sentences in one paragraph
  • Updated Xamarin link from http://developer.xamarin.com/api/root/classlib/ to https://docs.microsoft.com/xamarin/ [Or Xamarin mention can be removed?]

@BillWagner @mairaw please review.

jzeferino
jzeferino approved these changes Apr 10, 2018
View reviewed changes
Copy link
Contributor

@jzeferino jzeferino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense for me.

BillWagner
BillWagner approved these changes Apr 11, 2018
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @pkulikov

Thanks for updating this.

I'll :shipit: now.

Thanks again.

@BillWagner BillWagner merged commit 7263db4 into dotnet:master Apr 11, 2018
@pkulikov pkulikov deleted the patch-1 branch April 11, 2018 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@jzeferino jzeferino jzeferino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sprint 134 (4/7/2018 - 4/27/2018)
Development

Successfully merging this pull request may close these issues.
3 participants
@pkulikov @BillWagner @jzeferino